Ensure we are properly testing multiple Ember versions. #5123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit (since c2ca068) we were only testing ember-source@2.11. Even though we had a `config/ember-try.js` with many scenarios, none of them properly removed the `ember-source` version (even though ba7f462 was specifically trying to do this 😭). The fundamental issue here is: * `ember-try` supports removing packages, but requires that you specify them in the `dependencies` or `devDependencies` objects. Since my changes in ba7f462 added `"ember-source": null` to the root of the `npm` config it was completely ignored 😞. * `ember-source` emits a warning to the console when it is present **and** the bower package for `ember` is in use. Unfortunately, this warning is a bit misleading (it doesn't tell you that the `ember-source` from `npm` will always win). The `ember-source` addon should be updated to throw an error when this misconfiguration is detected. * `ember-cli` will **always** use `ember-source` if it is present, and completely ignore whatever is in `bower.json`. IMHO, this default was not correct and `ember-cli` should have done the same thing that `ember-data` did during its migration from bower to `npm`: if both packages are present default to `bower.json` version with a warning.
|
I'm very sorry I didn't properly handle this back in ba7f462 😭. |
|
Migrated from a warning to an error in emberjs/ember.js#15582. |
|
Looks like nearly all of the failures on ember-release, ember-beta, ember-canary, and ember-alpha channels are related to the Ember.MODEL_FACTORY_INJECTIONS deprecation. #5127 should fix those. |
|
I'm working on this for rob starting now. |
Avoid MODEL_FACTORY_INJECTION deprecations in tests on Ember >= 2.14.
stefanpenner
force-pushed
the
fix-ember-try-config
branch
from
b6877b7
to
a812747
Compare
|
fixed some more stuff, still some issues for: 1.13.x and 2.4.x |
|
Looking good @stefanpenner, looks like all but Ember 2.4 and 1.13 are passing now. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit (since c2ca068) we were only testing ember-source@2.11. Even though we had a
config/ember-try.jswith many scenarios, none of them properly removed theember-sourceversion (even though ba7f462 was specifically trying to do this 😭).The fundamental issue here is:
ember-trysupports removing packages, but requires that you specify themin the
dependenciesordevDependenciesobjects. Since my changes inba7f462 added
"ember-source": nullto the root of thenpmconfigit was completely ignored 😞.
ember-sourceemits a warning to the console when it is present andthe bower package for
emberis in use. Unfortunately, this warning isa bit misleading (it doesn't tell you that the
ember-sourcefromnpmwill always win). The
ember-sourceaddon should be updated to throw anerror when this misconfiguration is detected.
ember-cliwill always useember-sourceif it is present, andcompletely ignore whatever is in
bower.json. IMHO, this default was notcorrect and
ember-clishould have done the same thing thatember-datadid during its migration from bower to
npm: if both packages are presentdefault to
bower.jsonversion with a warning.There are almost certainly failing tests in the various scenarios. I pushed this in a branch so that others can help track down and fix the various issues.