Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update v4-main infra and tooling to match main branch #9598

Open
wants to merge 108 commits into
base: v4-main
Choose a base branch
from

Conversation

runspired
Copy link
Contributor

No description provided.

@runspired runspired self-assigned this Nov 12, 2024
NullVoxPopuli and others added 19 commits November 19, 2024 10:17
* Sync tests/main/tests/unit/record-arrays/record-array-test.js

* Sync tests/main/tests/unit/record-arrays/adapter-populated-record-array-test.js

* Get through most of unit/model
* Finish the models folder

* Add legacy-compat tests

* custom class model
update integration/records
* update tests/integration/references

* fix easier to fix integration/relationships tests

* update tests/integration/{serializers,store}

* fix tests in integration (no subdir)

* finish off unit tests (adapters, custom-class-support)

* update more integration tests

* all the tests migrated
@lfloyd117
Copy link

Any movement on this? This bug seems to be blocking us from getting to LTS of ember-data 4 so we can be prepared to move to 5

@runspired
Copy link
Contributor Author

@lfloyd117 what issue?

@lfloyd117
Copy link

@runspired
This: #8791
One of our devs said he talked to you and found there was this bug in ember-data 4.12 that blocked us and you were making this PR for an ember-data 4.13 that would fix the issue, that PR being this

@runspired
Copy link
Contributor Author

@lfloyd117 not familiar with a discussion with anyone on that specific ticket: that said, the idea of 4.13 is that it contains all fixes and additions from V5 (while attempting to preserve deprecated things present in V4). I notice that particular fix never got backported (probably no one ever asked for it to be, would have been an easy one to), but yes it will be fixed in 4.13 too.

@lfloyd117
Copy link

@runspired I can ask them to check on this thread later (they are on a different timezone and not on currently).
Is there any ETA on fixes for issues like that being backported to 4 via 4.13?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: needs triage
Development

Successfully merging this pull request may close these issues.

3 participants