Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npmignore: Do not publish yarn.lock file #329

Merged
merged 1 commit into from
May 25, 2018
Merged

npmignore: Do not publish yarn.lock file #329

merged 1 commit into from
May 25, 2018

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented May 15, 2018

@Turbo87 Turbo87 requested a review from rwjblue May 15, 2018 15:21
@rwjblue
Copy link
Member

rwjblue commented May 15, 2018

We should add yarn.lock or package-lock.json to the default blueprint's .npmignore...

@Turbo87
Copy link
Member Author

Turbo87 commented May 15, 2018

yeah, was just thinking the same thing...

@Turbo87
Copy link
Member Author

Turbo87 commented May 15, 2018

package-lock.json might not be necessary though

One key detail about package-lock.json is that it cannot be published

from https://docs.npmjs.com/files/package-lock.json

@Turbo87 Turbo87 mentioned this pull request May 15, 2018
Merged
@Turbo87 Turbo87 merged commit 01b22d0 into emberjs:master May 25, 2018
@Turbo87 Turbo87 deleted the yarn-ignore branch May 25, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @rwjblue