Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ModuleLoadFailure handling #330

Merged
merged 1 commit into from
May 31, 2018
Merged

Improve ModuleLoadFailure handling #330

merged 1 commit into from
May 31, 2018

Conversation

stefanpenner
Copy link
Member

  1. if only 1 error is found, throw that (rather then joining)
  2. after throwing, release errors captured in moduleLoadFailures

@stefanpenner
Improve ModuleLoadFailure handling
b7be02c 
1. if only 1 error is found, throw that (rather then joining)
2. after throwing, release errors captured in `moduleLoadFailures`
@stefanpenner stefanpenner requested a review from rwjblue May 31, 2018 21:38
@rwjblue rwjblue merged commit 27e1b64 into master May 31, 2018
@rwjblue rwjblue deleted the improve-module-load-failures branch May 31, 2018 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanpenner @rwjblue