Upgrade qunit to v2.7.1 #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
commented
Oct 17, 2018
| qunit@~2.7.1: | ||
| version "2.7.1" | ||
| resolved "https://registry.yarnpkg.com/qunit/-/qunit-2.7.1.tgz#ab93d322e46d8457d52fe4fa49d76da8cc476fec" | ||
| integrity sha512-ePeNs/CVL8coOWxnjxQAp9mCvRJybEQw3rwJe1TUClL+WrIcaZkLeW7VxHWtshn0L0ZtY0y80JqC7+po7330Ng== |
Turbo87
changed the title
Turbo87
approved these changes
Oct 17, 2018
|
released as v3.5.2 🎉 |
|
@stefanpenner this should have been v4.0.0 as it includes #354, which is a breaking change. please rerelease v3.5.1 as v3.5.3, and v3.5.2 as v4.0.0. also please make sure to update https://github.com/emberjs/ember-qunit/blob/master/CHANGELOG.md, which would have made the situation more visible. I think @rwjblue also wanted to make #348 part of v4.0.0, so maybe we shouldn't publish v4.0.0 just yet anyway... |
|
I guess we need to republish 3.5.1 as 3.5.3, and get 4.0.0 out with this change. |
|
bah |
|
@stefanpenner I'm not sure how to interpret this comment |
|
I have re-released v3.5.1 as v3.5.3 and updated the changelog, the v4.0.0 release will follow later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qunitjs/qunit#1319 (comment)