Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent leakage of position fixed elements from the testing container #571

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

nickschot
Copy link
Contributor

Having recently worked on an app with a lot of position: fixed present I got annoyed by everything visually leaking from the #ember-testing-container element. This cool trick prevents that from happening and keeps everything where it should be.

Per W3 spec ( https://www.w3.org/TR/css-transforms-1/#transform-rendering ):

For elements whose layout is governed by the CSS box model, any value other than none for the transform property also causes the element to establish a containing block for all descendants. Its padding box will be used to layout for all of its absolute-position descendants, fixed-position descendants, and descendant fixed background attachments.

@rwjblue
Copy link
Member

rwjblue commented Oct 16, 2019

CI is broken due to Node 6 issues 😭

@nickschot
Copy link
Contributor Author

Awww I felt like a wizard breaking CI with 1 line of CSS

@rwjblue rwjblue merged commit 78b2239 into emberjs:master Oct 23, 2019
@rwjblue rwjblue changed the title prevent leakage of position fixed elements from the testing container Prevent leakage of position fixed elements from the testing container Oct 23, 2019
@nickschot nickschot deleted the fix-testing-container-leakage branch October 23, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants