Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this addon is still supporting node 10, it isn't that easy to update to eai v2, as that requires node 12+.
So I first tried to set the dependency to
"ember-auto-import": "^1.11.3 || ^2.2.4"
, but that threw an error on install time that the node engine was incompatible. Weirdly, that even happened when also setting a yarn resolution to^1.11.3
locally 🤔Now, I ended up allowing
>= ^1.11.3 < 3
, and adding a local resolution to^1.11.3
, which seemed to do the trick. As far as I can tell, this addon itself is not doing anything special with eai, so both v1 and v2 should generally work fine in a host app.Once this addon drops support for node 10, we can remove the resolution (and do
yarn add webpack --dev
) and use eai 2 locally.Closes #902