Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ember-auto-import v1 or v2 #913

Closed
wants to merge 1 commit into from

Conversation

mydea
Copy link
Contributor

@mydea mydea commented Dec 10, 2021

Since this addon is still supporting node 10, it isn't that easy to update to eai v2, as that requires node 12+.
So I first tried to set the dependency to "ember-auto-import": "^1.11.3 || ^2.2.4", but that threw an error on install time that the node engine was incompatible. Weirdly, that even happened when also setting a yarn resolution to ^1.11.3 locally 🤔

Now, I ended up allowing >= ^1.11.3 < 3, and adding a local resolution to ^1.11.3, which seemed to do the trick. As far as I can tell, this addon itself is not doing anything special with eai, so both v1 and v2 should generally work fine in a host app.

Once this addon drops support for node 10, we can remove the resolution (and do yarn add webpack --dev) and use eai 2 locally.

Closes #902

@mehulkar
Copy link

Since this addon is still supporting node 10

can we drop node 10 support? ember-cli doesn't support it either anymore

@SergeAstapov
Copy link

Agree with @mehulkar, we should just have a new major of this adding dropping support for Node 10 and adding e-a-i v2

@mydea
Copy link
Contributor Author

mydea commented Jan 26, 2022

I'm also fine with that, whatever is the preferred solution. Happy to update the PR, if I should do so? But would be great to get this landed one way or another :)

@CvX
Copy link

CvX commented Jun 27, 2022

Anything blocking this PR? 😃

@CvX CvX mentioned this pull request Jun 27, 2022
@locks
Copy link
Contributor

locks commented Jul 25, 2022

Closed by #921.

@locks locks closed this Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to ember-auto-import@2
5 participants