Refactor to use the extracted lib ember-test-helpers #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core logic in ember-qunit has been extracted to switchfly/ember-test-helpers. This library now wraps ember-test-helpers with qunit-specific helpers.
| }); | ||
| } | ||
|
|
||
| var a = 0; |
There was a problem hiding this comment.
Any chance a and b could be renamed? Its pretty hard to follow the test logic with all the += and -=
There was a problem hiding this comment.
I am open to suggestions to improve the clarity of those tests. They really have to be analyzed as a complete set due to the nature of what they're testing (test setup / teardown).
rwjblue
added a commit
that referenced
this pull request
Oct 28, 2014
Refactor to use the extracted lib ember-test-helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the core logic from ember-qunit into switchfly/ember-test-helpers. This library now simply wraps ember-test-helpers with QUnit-specific helpers. This approach allows other libraries, such as ember-mocha, to share the same internals.
This PR also removes the
dist/dir. @rwjblue favors creating a separate bower repo for distribution.Also, karma has been replaced with testem to be consistent with ember-cli and its related libraries.
Credit for backing all of this work, including the development of ember-test-helpers and ember-mocha, goes to my client Switchfly. Many thanks to them!