Set Ember.testing only while actually running a test. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `Ember.testing` was set to `true` in module scope of `ember-test-helpers` module. This causes issues due to how Ember handles RSVP promises that happen while `Ember.testing` is truthy. This commit updates the various machinery to set `Ember.testing = true` when tests are starting, and reset it to `false` once they've finished their teardown. It also adds assertions to ensure that each test properly cleans up after itself. Note: In some cases, instead of adding new assertions I used `throw new Error()`. This was only done in the "legacy" tests as a way of ensuring the required functionality without modifying all `assert.expect()` counts throughout those test files.
bgentry
added a commit
to ember-graphql/ember-apollo-client
that referenced
this pull request
Dec 17, 2017
Module destructures are evaluated at build time, but this value is changed dynamically at runtime. Avoiding the destructure is the only way to work given this behavior. See these issues: mainmatter/ember-simple-auth#1476 emberjs/ember-test-helpers#227
This was referenced Dec 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Ember.testingwas set totruein module scope ofember-test-helpersmodule. This causes issues due to how Ember handles RSVP promises that happen whileEmber.testingis truthy.This commit updates the various machinery to set
Ember.testing = truewhen tests are starting, and reset it tofalseonce they've finished their teardown. It also adds assertions to ensure that each test properly cleans up after itself.Note: In some cases, instead of adding new assertions I used
throw new Error(). This was only done in the "legacy" tests as a way of ensuring the required functionality without modifying allassert.expect()counts throughout those test files.Partially addresses emberjs/ember-qunit#246.