Make tests at least boot in IE and sort package.json alphabetically #272
Conversation
vendor/monkey-patches.js
Outdated
| @@ -21,7 +21,7 @@ | |||
| // that happen _between_ acceptance tests will always share | |||
| // `pendingRequests`. | |||
| _Ember.Application.reopen({ | |||
| willDestroy() { | |||
| willDestroy: function() { | |||
There was a problem hiding this comment.
with #271 this should not be necessary anymore
package.json
Outdated
| "ember-data": "~2.17.0", | ||
| "ember-debug-handlers-polyfill": "^1.0.3", | ||
| "ember-disable-prototype-extensions": "^1.1.2", | ||
| "ember-fetch": "^3.4.0", | ||
| "ember-load-initializers": "^1.0.0", | ||
| "ember-maybe-import-regenerator": "^0.1.6", |
There was a problem hiding this comment.
we should probably use https://github.com/ember-cli/ember-maybe-import-regenerator-for-testing instead since the production code should not use async/await
There was a problem hiding this comment.
Agreed, and just to be clear we do have linting setup to catch any async / await usage in addon-test-support...
package.json
Outdated
| "ember-cli-shims": "^1.2.0", | ||
| "ember-cli-test-loader": "^2.2.0", | ||
| "ember-cli": "^2.17.1", |
There was a problem hiding this comment.
I don't think that is the default order that npm and yarn use. I usually use https://github.com/keithamus/sort-package-json to sort this correctly.
tests/dummy/config/targets.js
Outdated
| @@ -1,4 +1,9 @@ | |||
| /* eslint-env node */ | |||
| module.exports = { | |||
| browsers: ['last 1 Chrome versions', 'last 1 Firefox versions', 'last 1 Safari versions'], | |||
| browsers: [ | |||
| 'ie 11', | |||
There was a problem hiding this comment.
Lets do this conditionally? I really like debugging with native async/await, and we only need IE11 support in smaller cases.
I was thinking of something like: http://rwjblue.com/2017/10/30/async-await-configuration-adventure/#10limittargetsduringlocaldevelopmenttesting
cibernox
force-pushed
the
make-x-broser-compatible-part-1
branch
from
c6ede32
to
cfb9d8a
Compare
cibernox
force-pushed
the
make-x-broser-compatible-part-1
branch
from
cfb9d8a
to
868997b
Compare
No description provided.