Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to generate into API.md. #294

Merged
merged 4 commits into from
Dec 31, 2017

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Dec 30, 2017

  • update docs script to inject into README
  • remove old / outdated docs in README
  • remove gh-pages auto-deployment

Rendered README.md for easier reviewing...

It doesn't work at the moment due to an issue with emberjs/website
(which also deploys via gh-pages for the whole emberjs org).

For now (in order to get the docs "out there") we will add them as a
markdown to the repo that is updated when releases are prepared (e.g.
the same time as the changelog is generated).
README.md Outdated
The exact listing of events that are triggered may change over time as needed
to continue to emulate how actual browsers handle clicking a given element.

**Parameters**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile this renders the same as the h4 of the functions which makes it somewhat hard to read and find stuff 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that is also true on desktop.

README.md Outdated
* `yarn install`
- `git clone <repository-url>` this repository
- `cd ember-test-helpers`
- `yarn install`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO it's quite annoying that documentation is reformatting the whole file when it's only supposed to replace a single section. I've had the same issue in qunit-dom and decided to have it output in a API.md instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, agreed that its odd.

- blur
- triggerEvent
- triggerKeyEvent
- fillIn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this at first, but it looked strange in the HTML version. Is this still the case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this only works for the md version. If you do children: in the HTML formatted output its really really weird.

@rwjblue
Copy link
Member Author

rwjblue commented Dec 31, 2017

FWIW, I don't think this is a "final" solution. I just spent so much damned time on the docs, and I'd like to have something to show for it while we figure out a deployment strat for the HTML formatted output...

@Turbo87
Copy link
Member

Turbo87 commented Dec 31, 2017

aye, I think I'd still prefer an API.md though 🤔

@rwjblue rwjblue merged commit 3c4731b into emberjs:master Dec 31, 2017
@rwjblue rwjblue deleted the interaction-helpers-root branch December 31, 2017 01:51
@rwjblue rwjblue changed the title Update documentation to generate into README. Update documentation to generate into API.md. Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants