Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure view is set by default on generated mouse events #429

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

mydea
Copy link
Contributor

@mydea mydea commented Oct 16, 2018

This PR adds window as default view on generated mouse events.

This fixes #426

@cibernox
Copy link
Contributor

I had no idea the view property was important, I never saw any code that failed because of that.
LGTM

@mydea
Copy link
Contributor Author

mydea commented Oct 16, 2018

I guess D3 is a bit special ;)

@cibernox
Copy link
Contributor

The failure looks random. Can you amend and push again?

@mydea
Copy link
Contributor Author

mydea commented Oct 16, 2018

Done, passed now!

@cibernox cibernox merged commit bd21165 into emberjs:master Oct 16, 2018
@rwjblue
Copy link
Member

rwjblue commented Oct 16, 2018

Thank you @mydea!

@rwjblue rwjblue added the bug label Oct 16, 2018
rwjblue pushed a commit that referenced this pull request Oct 16, 2018
@rwjblue
Copy link
Member

rwjblue commented Oct 16, 2018

@ember/test-helpers 0.7.27 published 🎉

@mydea mydea deleted the fix-click-view branch July 19, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to 0.7.26 breaks d3-drag
3 participants