Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.13 and dom attributes with number literals #15217

Closed
thec0keman opened this issue May 9, 2017 · 0 comments
Closed

2.13 and dom attributes with number literals #15217

thec0keman opened this issue May 9, 2017 · 0 comments

Comments

@thec0keman
Copy link

With the following mustache:

<td colspan={{3}}>

This is thrown:

TypeError: Cannot read property 'length' of undefined
    at TransFormDotComponentInvocation._isMulipartPath (VM151 ember-template-compiler.js:14387)
    at TransFormDotComponentInvocation._isInlineInvocation (VM151 ember-template-compiler.js:14391)
    at MustacheStatement (VM151 ember-template-compiler.js:14416)
    at visitNode (VM151 ember-template-compiler.js:2753)
    at visitKey (VM151 ember-template-compiler.js:2791)
    at visitNode (VM151 ember-template-compiler.js:2767)
    at visitArray (VM151 ember-template-compiler.js:2805)
    at visitKey (VM151 ember-template-compiler.js:2789)
    at visitNode (VM151 ember-template-compiler.js:2767)
    at visitArray (VM151 ember-template-compiler.js:2805)

This works up through 2.12, but breaks in 2.13.

Twiddle
@HeroicEric HeroicEric mentioned this issue Nov 1, 2017
Closed
Serabe added a commit to Serabe/ember.js that referenced this issue Nov 1, 2017
@Serabe
[BUGFIX beta] Fix dot-component invocation predicate
ed9a7e0 
A BooleanLiteral has no parts, so the following template was raising
an issue: `<input disabled={{true}} />`.

Also happens with integers and other literals.

Closes emberjs#15217
Closes emberjs#15740
@Serabe Serabe mentioned this issue Nov 1, 2017
Merged
@Darshan-Chauhan Darshan-Chauhan mentioned this issue Jun 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thec0keman