Deprecate the non-block {{with}} syntax #10584
Conversation
| if (node.program && node.program.blockParams.length) { | ||
| throw new Error('You cannot use keyword (`{{with foo as bar}}`) and block params (`{{with foo as |bar|}}`) at the same time.'); | ||
| } | ||
|
|
||
| Ember.deprecate( |
There was a problem hiding this comment.
Does Ember.deprecate work in Node where this is used? Are deprecations displayed to the user in ember-cli?
There was a problem hiding this comment.
Yes, it should work, but I'll try to confirm.
There was a problem hiding this comment.
Good question. It works in tests, but it could be different in actual usage.
There was a problem hiding this comment.
I could also set a flag here and then do the actual deprecation in the {{with}} helper.
There was a problem hiding this comment.
Looks like doing it in the transform is preferred since we get the alerts at compile time.
|
👍 |
| @@ -73,7 +73,7 @@ export function withHelper(params, hash, options, env) { | |||
| } else { | |||
| Ember.deprecate( | |||
| "Using the context switching form of `{{with}}` is deprecated. " + | |||
| "Please use the keyword form (`{{with foo as bar}}`) instead.", | |||
| "Please use the block form (`{{#with foo as |bar|}}`) instead.", | |||
There was a problem hiding this comment.
I believe this should be "block params" not "block" since both the good and bad forms are actually blocks. The thing we want to convey is that they should use the block param instead of {{#with foo as bar}}.
wagenet
force-pushed
the
deprecate-non-block-with
branch
from
4776104
to
16dfc07
Compare
wagenet
force-pushed
the
deprecate-non-block-with
branch
from
16dfc07
to
f283359
Compare
|
Rebased. |
wagenet
force-pushed
the
deprecate-non-block-with
branch
from
f283359
to
60e06bb
Compare
| "Using {{with}} without block syntax is deprecated. " + | ||
| "Please use standard block form (`{{#with foo as |bar|}}`) instead.", | ||
| false, | ||
| { url: "http://emberjs.com/guides/deprecations/#toc_deprecate-non-block-params-with-syntax" } |
There was a problem hiding this comment.
I believe that this needs to be updated to point to the new location, c/d?
wagenet
force-pushed
the
deprecate-non-block-with
branch
2 times, most recently
from
d5181a4
to
aeb5571
Compare
|
Looks like a few failures in the deprecation. |
wagenet
force-pushed
the
deprecate-non-block-with
branch
from
aeb5571
to
9985469
Compare
|
@rwjblue fixed now. |
Deprecate the non-block {{with}} syntax
Depends on merge of emberjs/guides#63