[BUGFIX beta] Ensure new Registry created with app instance #10597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the PR @rwjblue |
|
@mutewinter needs test @dgeb r? |
Not sure how to write a test for this. |
|
@dgeb @stefanpenner guidance for a test would be great |
|
I think I'm still getting bitten by this; any update? |
|
I'm happy to help with the test here, but I need someone to help me with understanding the failure scenario (and to confirm it is still an issue)... |
|
The entire purpose of the registry is that it is shared by many instances, so I'm doubtful that this is the right fix. Closing for now, and continuing the conversation in #10310. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #10310