Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded things that create many mixins and merges. #16772

Merged
merged 1 commit into from
Jun 23, 2018
Merged

Remove unneeded things that create many mixins and merges. #16772

merged 1 commit into from
Jun 23, 2018

Conversation

krisselden
Copy link
Contributor

No description provided.

@krisselden
Copy link
Contributor Author

krisselden commented Jun 22, 2018 •
edited

The mixin polymorphism in ember-data was reaching into modelClass.PrototypeMixin relying on this including inherited mixins which was totally a mistake. /cc @runspired

@rwjblue rwjblue merged commit 7b1fc36 into master Jun 23, 2018
@rwjblue rwjblue deleted the cleanup-core-object branch June 23, 2018 00:18
@rwjblue
Copy link
Member

rwjblue commented Jun 23, 2018

Ya, we will need to clean that up to something like meta(modelClass.proto()).hasMixin(thing).

@runspired
Copy link
Contributor

cc @igorT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krisselden @rwjblue @runspired