Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Implements the Computed Property Modifier deprecation RFCs #17470

Merged
merged 2 commits into from Jan 17, 2019

Conversation

Projects
None yet
2 participants
@pzuraq
Copy link
Contributor

pzuraq commented Jan 11, 2019

  • Deprecates .property()
  • Deprecates .volatile()
  • Deprecates clobberSet internally
  • Keeps injected properties and the store property on routes
    overridable for testing purposes
  • Rewrites lots of usages in tests. For some reason volatile was
    frequently used in tests when it was not needed.
  • Adds additionalDependentKeys array to map, filter and sort
    array functions. sort was overlooked in RFC, but suffers from the
    same problem so it shouldn't need an additional RFC.
  • Adds tests for additionalDependentKeys

@pzuraq pzuraq force-pushed the pzuraq:deprecation/computed-modifiers branch from 458a049 to 229c0bf Jan 11, 2019

@pzuraq

This comment has been minimized.

Copy link
Contributor Author

pzuraq commented Jan 11, 2019

Deprecation doc PR here

[FEAT] Implements the Computed Property Modifier deprecation RFCs
- Deprecates `.property()`
- Deprecates `.volatile()`
- Deprecates `clobberSet` internally
- Keeps injected properties and the `store` property on routes
  overridable for testing purposes
- Rewrites lots of usages in tests. For some reason `volatile` was
  frequently used in tests when it was not needed.
- Adds `additionalDependentKeys` array to `map`, `filter` and `sort`
  array functions. `sort` was overlooked in RFC, but suffers from the
  same problem so it shouldn't need an additional RFC.
- Adds tests for `additionalDependentKeys`

@pzuraq pzuraq force-pushed the pzuraq:deprecation/computed-modifiers branch from 229c0bf to f3693d6 Jan 11, 2019

@rwjblue
Copy link
Member

rwjblue left a comment

Awesome job, thank you!

@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Jan 12, 2019

CI failure is due to linting:


/home/travis/build/emberjs/ember.js/packages/@ember/-internals/metal/lib/computed.ts
  479:23  error  Replace `obj` with `⏎········obj⏎······`  prettier/prettier
✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

@pzuraq pzuraq force-pushed the pzuraq:deprecation/computed-modifiers branch from 1e7d959 to 95973cf Jan 12, 2019

@rwjblue
Copy link
Member

rwjblue left a comment

Deprecation guide PR landed in ember-learn/deprecation-app#254, and I confirmed URL's for deprecations...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.