[FEAT] Implements the Computed Property Modifier deprecation RFCs #17470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
deprecation/computed-modifiers
branch
from
458a049
to
229c0bf
Compare
|
Deprecation doc PR here |
- Deprecates `.property()` - Deprecates `.volatile()` - Deprecates `clobberSet` internally - Keeps injected properties and the `store` property on routes overridable for testing purposes - Rewrites lots of usages in tests. For some reason `volatile` was frequently used in tests when it was not needed. - Adds `additionalDependentKeys` array to `map`, `filter` and `sort` array functions. `sort` was overlooked in RFC, but suffers from the same problem so it shouldn't need an additional RFC. - Adds tests for `additionalDependentKeys`
pzuraq
force-pushed
the
deprecation/computed-modifiers
branch
from
229c0bf
to
f3693d6
Compare
rwjblue
approved these changes
Jan 11, 2019
|
CI failure is due to linting: |
pzuraq
force-pushed
the
deprecation/computed-modifiers
branch
from
1e7d959
to
95973cf
Compare
rwjblue
approved these changes
Jan 17, 2019
There was a problem hiding this comment.
Deprecation guide PR landed in ember-learn/deprecation-app#254, and I confirmed URL's for deprecations...
This was referenced Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.property().volatile()clobberSetinternallystoreproperty on routesoverridable for testing purposes
volatilewasfrequently used in tests when it was not needed.
additionalDependentKeysarray tomap,filterandsortarray functions.
sortwas overlooked in RFC, but suffers from thesame problem so it shouldn't need an additional RFC.
additionalDependentKeys