This repository has been archived by the owner on May 26, 2019. It is now read-only.
update brace expansion example #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbatson5
force-pushed
the
sb-brace-expansion
branch
from
c6e6fbe
to
23c370d
Compare
locks
approved these changes
Mar 19, 2018
|
Thanks for the tweak :) |
|
Nice work @sbatson5, you just passed Tom 😀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fixes #2291
This updates the example on
brace expansionon dependent keys of computed properties. The existing example used keys on the same object as the CP but in my experience, this has been considered bad practice. This update also shortens this section (which never hurts :P )