Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

update templates section to use CLI syntax #71

Merged
merged 1 commit into from
Mar 23, 2015

Conversation

mikepmunroe
Copy link
Contributor

update all docs in templates to utilize CLI syntax
there is still an image in Actions that is old syntax that need updating
action-bubbling

@@ -31,12 +31,12 @@ value.

### Dependencies

Imagine you want to render the full name of an `App.Person`. In this
Imagine you want to render the full name of an `Person`. In this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"an Person"

This template will be compiled automatically and become your
[application template](../../templates/the-application-template),
which will be displayed on the page when your app loads.
By default, adjust your [application template](/templates/the-application-template), that is created automatically for you and will be displayed on the page when your app loads.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link needs to be relative.

@trek
Copy link
Member

trek commented Mar 21, 2015

We'll just suffer the image for a while. Can you address the one comment and then squash this commit?

@mikepmunroe
Copy link
Contributor Author

@trek made link updates and squashed commit. I'm not a master of Photoshop, but I'll find a tutorial for adjusting the text within the image and try to make it look nice. When I have a chance to try, I'll submit another PR for just that change.

@trek
Copy link
Member

trek commented Mar 22, 2015

@mikepmunroe that image comes from OmniGraffle, which is obviously not great for us to use. If you have the time, it'd be great to migrate that diagram to https://github.com/knsv/mermaid and create (of find) a mermaid extension for middleman.

I can create a Quest Issue if you need more context than that.

@locks
Copy link
Contributor

locks commented Mar 23, 2015

:shipit:

trek added a commit that referenced this pull request Mar 23, 2015
update templates section to use CLI syntax
@trek trek merged commit 34fd118 into emberjs:master Mar 23, 2015
```js
App.PostController = Ember.ObjectController.extend({
```app/controllers/post.js
export default Ember.ObjectController.extend({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to update examples that use ObjectController.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants