-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate setupComponentManager String Lookup #392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadhietala
changed the title
Deprecate string api
Deprecate setupComponentManager String Lookup
Oct 23, 2018
locks
requested changes
Oct 23, 2018
Co-Authored-By: chadhietala <chadhietala@gmail.com>
Co-Authored-By: chadhietala <chadhietala@gmail.com>
Co-Authored-By: chadhietala <chadhietala@gmail.com>
Co-Authored-By: chadhietala <chadhietala@gmail.com>
Co-Authored-By: chadhietala <chadhietala@gmail.com>
Co-Authored-By: chadhietala <chadhietala@gmail.com>
Co-Authored-By: chadhietala <chadhietala@gmail.com>
rwjblue
approved these changes
Oct 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thank you for the artisanally crafted deprecation RFC.
locks
approved these changes
Oct 23, 2018
14 tasks
rwjblue
added
T-framework
RFCs that impact the ember.js library
T-components
T-deprecation
Final Comment Period
labels
Oct 24, 2018
Moving into FCP... |
tylerturdenpants
added a commit
to emberjs/website
that referenced
this pull request
Oct 26, 2018
Ideas, feel free to add to list or claim! - [ ] I've been getting a lot of questions about how tree-shaking is coming along. I would be willing to train anyone that wants to help on what's already done and what still needs to be done. Disclaimer: It's a lot of work! https://twitter.com/kellyselden/status/1050717338595745792 - [x] emberjs/rfcs#387 it seems this was covered in [last week's edition](https://www.emberjs.com/blog/2018/10/19/the-ember-times-issue-69.html#toc_a-href-https-github-com-emberjs-rfcs-pull-387-using-relationships-links-or-not-your-call-a) - [ ] emberjs/rfcs#389 - [x] emberjs/rfcs#391 (:lock: @jessica-jordan) - [x] emberjs/rfcs#392 (:lock: @jessica-jordan) - [ ] Hacktoberfest roundup? - [ ] Check https://github.com/jessica-jordan/whats-new-in-emberland (roundup of all the PRs in emberjs and ember-learn repos) - [x] GraphQL with Ember? https://emberfest.eu/schedule/#rocky-neurock Or maybe we can reach out to them for a post-EmberFest writeup? See also the blog post: https://medium.com/kloeckner-i/ember-and-graphql-8aa15f7a2554 cc @simonihmig (:lock: @amyrlam) - [ ] #30DaysOfEmber https://twitter.com/PoslinskiNet/status/1054446639719608320 - [x] Following the spirit of building shared solutions, ember-i18n is now deprecated in favor of ember-intl (https://github.com/ember-intl/ember-intl …)! Now we have a blessed way to internationalize Ember apps! Check the codemod we built @DockYard to help with the migration https://twitter.com/MiguelCamba/status/1054699605865177089 (🔒 @chrisrng ) - [x] Ember 3.5 released! (🔏 @kennethlarsen) Ideas we are waiting on: - [ ] EmberCamp talks, deep dive? http://embercamp.com/ and https://github.com/ember-chicago/ember-camp-2018-notes ... Maybe we wait for the talk videos to be published? Keep an eye on #ember-camp in Discord. - [ ] EmberFest talks, deep dive? Keep an eye on #ember-fest in Discord. - [ ] Include summary from pixelhandler (get input from him), see #issue-triage in Discord (check toward end of October)
Wheeeeeee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
This RFC has been artisanally crafted for @rwjblue.