Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Numeric Comparison Operators to Templates #561

Open
wants to merge 1 commit into
base: master
from

Conversation

@cibernox
Copy link
Contributor

cibernox commented Dec 8, 2019

Extracted from RFC #388

Rendered

Copy link
Member

Turbo87 left a comment

yes, please! 🙏

- The proposed version of those helpers mimic the behavior of the `<` and `>` operators in Javascript. While this is the
least surprising thing to do, one could argue that we could add extra logic to protect users from the usual pitfalls
and edge cases of those operators, **like throwing exceptions if any of the values is `NaN` or a value other than a number**.
- We must decide if it's worth adding `{{lte}}` and `{{gte}}` helpers, equivalent to `<=` and `>=` respectively.

This comment has been minimized.

Copy link
@Turbo87

Turbo87 Dec 18, 2019

Member

I think I would prefer having them supported too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.