Modernize built-in components (part 2) #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
added
T-components
T-framework
CvX
reviewed
Jan 15, 2021
37 tasks
|
We discussed this at todays core team meeting, and are moving it into final comment period. |
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
ro0gr
reviewed
Jan 20, 2021
| element for navigation is not recommended as it creates issues with assistive | ||
| technologies. Remove this argument to use the default <a> element. In the rare | ||
| cases that calls for using a different element, refactor to use the router | ||
| service inside a custom event handler instead. |
There was a problem hiding this comment.
Does it make sense to have a link here to appropriate section of the RFC, to provide more context, and detailed description like it is in the RFC.
This "no longer recommended" feels like a soft form of deprecations. But deprecations typically have their link.
See discussion on emberjs/ember.js#19348
|
Rendered link is a 404? |
Fixed now. Generally this is a problem after merging the RFCs because while still in PRs, the rendered links points to the branch, but once it's merged the branch is deleted and it lives on the master branch instead, so the link would have to be updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered