-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize built-in components (part 2) #707
Conversation
We discussed this at todays core team meeting, and are moving it into final comment period. |
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
element for navigation is not recommended as it creates issues with assistive | ||
technologies. Remove this argument to use the default <a> element. In the rare | ||
cases that calls for using a different element, refactor to use the router | ||
service inside a custom event handler instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to have a link here to appropriate section of the RFC, to provide more context, and detailed description like it is in the RFC.
This "no longer recommended" feels like a soft form of deprecations. But deprecations typically have their link.
See discussion on emberjs/ember.js#19348
Rendered link is a 404? |
Fixed now. Generally this is a problem after merging the RFCs because while still in PRs, the rendered links points to the branch, but once it's merged the branch is deleted and it lives on the master branch instead, so the link would have to be updated |
Rendered