-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize use of scripts in package.json for common tasks #831
Conversation
> There are tradeoffs to choosing any path, please attempt to identify them here. | ||
|
||
## Alternatives | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as an alternative, I would like all options presented all the time, (via global tab system) like how Microsoft and Starbeam do
clicking the tab for pnpm/npm/yarn changes the tabs everywhere
from: https://starbeamjs.com/frameworks/react/1-getting-started.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The learning team & friends are building in something like this in order to support TypeScript + JS in our docs. I would love to have all 3 here as well.
Just adding a note here that I will be the core team champion for this RFC. |
Co-authored-by: Jen Weber <weberj10@gmail.com>
@MehulKChaudhari @Dhanush027 Today the Framework team reviewed this RFC, and they had some suggestions to help make it more broadly applicable! Let me know if you want help making any of these changes:
After we make these revisions, we can communicate that this RFC is in FCP (final comment period) which will be a good opportunity to invite people to take another look, or a look for the first time. |
I'd like to help to make these changes to RFC. |
Yes I would like to help with point 2, 3, and 4 |
👋 Hi, wondering what the status is of this RFC? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aesthetic suggestions.
Co-authored-by: MrChocolatine <47531779+MrChocolatine@users.noreply.github.com>
Co-authored-by: MrChocolatine <47531779+MrChocolatine@users.noreply.github.com>
Co-authored-by: MrChocolatine <47531779+MrChocolatine@users.noreply.github.com>
Co-authored-by: MrChocolatine <47531779+MrChocolatine@users.noreply.github.com>
Co-authored-by: MrChocolatine <47531779+MrChocolatine@users.noreply.github.com>
Co-authored-by: MrChocolatine <47531779+MrChocolatine@users.noreply.github.com>
@MehulKChaudhari are you able to update the RFC so the checks pass? @jenweber can help you! |
sure will do that |
It looks like our linter does not correctly ignore new files in the images folder. Should we merge without a green linter for this one, assuming consensus for the RFC content? Comment out that linter? Someone could fix it real quick in another PR? I would like this to not be blocked by our tooling. |
@kategengler do you have time to help out with the tooling? |
@jenweber worth nothing you'll have to open the advancement PR yourself using https://github.com/emberjs/rfcs/blob/master/.github/READTHIS.md#trigger-opening-advancement-pryml |
Advance RFC #831 `"Standardize use of scripts in package.json for common tasks"` to Stage Released
Advance RFC #831 `"Standardize use of scripts in package.json for common tasks"` to Stage Recommended
Rendered text
Standardize the use of yarn and npm scripts in the Ember experience
This change encourages developers to use
npm
oryarn
for certain commands when working with Ember applications, rather than using global Ember CLI commands likeember serve
. This aligns Ember with norms in the JavaScript community and helps in reducing the confusion around Ember-specific commands.