Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 migration integration branch #912

Merged
merged 107 commits into from
Jun 24, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented May 30, 2024

Goal

Integration branch for v2 payload migration.

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 84.66819% with 67 lines in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (1215e12) to head (b9782d8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
- Coverage   80.18%   78.98%   -1.21%     
==========================================
  Files         454      416      -38     
  Lines       12053    11052    -1001     
  Branches     1851     1764      -87     
==========================================
- Hits         9665     8729     -936     
+ Misses       1589     1541      -48     
+ Partials      799      782      -17     
Files Coverage Δ
...io/embrace/android/embracesdk/anr/AnrOtelMapper.kt 87.17% <100.00%> (ø)
.../embracesdk/anr/detection/BlockedThreadDetector.kt 83.78% <ø> (+0.85%) ⬆️
...embracesdk/anr/detection/LivenessCheckScheduler.kt 75.86% <ø> (-0.71%) ⬇️
...ndroid/embracesdk/anr/sigquit/SigquitDataSource.kt 32.14% <100.00%> (-4.53%) ⬇️
...droid/embracesdk/arch/datasource/SpanDataSource.kt 100.00% <100.00%> (ø)
...e/android/embracesdk/arch/destination/LogWriter.kt 100.00% <100.00%> (ø)
...droid/embracesdk/arch/destination/LogWriterImpl.kt 94.11% <100.00%> (-1.13%) ⬇️
...ndroid/embracesdk/capture/aei/AeiDataSourceImpl.kt 83.78% <100.00%> (-1.47%) ⬇️
...dk/capture/connectivity/NetworkStatusDataSource.kt 94.11% <100.00%> (-1.89%) ⬇️
...racesdk/capture/crumbs/EmbraceBreadcrumbService.kt 54.16% <ø> (+7.73%) ⬆️
... and 93 more

... and 12 files with indirect coverage changes

priettt and others added 23 commits June 13, 2024 16:31
It's already passed as a parameter to the EmbraceLogService construction.
Remove unnecessary parameters from log counter
Set device free disk bytes to null when not available
Use correct method signature for sigquit
@fractalwrench fractalwrench marked this pull request as ready for review June 24, 2024 16:33
@fractalwrench fractalwrench requested a review from a team as a code owner June 24, 2024 16:33
@fractalwrench fractalwrench changed the title [WIP] Integration/v2 migration V2 migration integration branch Jun 24, 2024
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets. Effing. GO!

@fractalwrench fractalwrench merged commit c560253 into master Jun 24, 2024
3 of 4 checks passed
@fractalwrench fractalwrench deleted the integration/v2-migration branch June 24, 2024 16:38
Copy link
Contributor

@priettt priettt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants