Add auto_bounds/set_auto_bounds to PlotUi
#3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
changed the title
abey79
changed the title
Wumpf
approved these changes
Nov 20, 2023
| @@ -854,7 +854,7 @@ impl Plot { | |||
| PlotMemory::load(ui.ctx(), plot_id) | |||
| } | |||
| .unwrap_or_else(|| PlotMemory { | |||
| auto_bounds: true.into(), | |||
| auto_bounds: default_auto_bounds, | |||
There was a problem hiding this comment.
was wondering about this one on the previous PR that added default_auto_bounds. Got me, I should have commented 😄
There was a problem hiding this comment.
Yeah the default_auto_bounds were just renamed, so that was a pre-existing bug I believe.
4 tasks
Base automatically changed from
antoine/plot-auto-bounds-api-part-1
to
master
November 21, 2023 10:22
abey79
force-pushed
the
antoine/plot-auto-bounds-api-part-2
branch
from
66ca3bf
to
cc6f3df
Compare
emilk
changed the title
auto_bounds/set_auto_bounds to PlotUi
abey79
added a commit
to rerun-io/rerun
that referenced
this pull request
Dec 1, 2023
…in timeseries space views (#4270) ### What * Fixes #4246 * Depends on emilk/egui#3586 * Blocked on #4111  ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4270) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4270) - [Docs preview](https://rerun.io/preview/2706326572e06cf2623136a62fee75d75b490fdd/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/2706326572e06cf2623136a62fee75d75b490fdd/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Andreas Reich <r_andreas2@web.de> Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Wumpf
pushed a commit
that referenced
this pull request
Dec 19, 2023
These PR recently cleaned up the code around auto-bounds, but introduced an involuntary change whereby auto-bounds would not be enabled by default. All plots would default to being not properly centred as a result. - #3587 - #3586 This PR changes the default back to enabled. It also deprecates `auto_bounds_x()` and `auto_bounds_y()`, which could only enable auto-bounds (which is not very useful as auto-bounds were, and now are again, enabled by default). A new `auto_bounds()` API can now be sued to disable auto-bounds if needed. Fixes #3712 Fixes rerun-io/rerun#4503
emilk
pushed a commit
that referenced
this pull request
Jan 3, 2024
These PR recently cleaned up the code around auto-bounds, but introduced an involuntary change whereby auto-bounds would not be enabled by default. All plots would default to being not properly centred as a result. - #3587 - #3586 This PR changes the default back to enabled. It also deprecates `auto_bounds_x()` and `auto_bounds_y()`, which could only enable auto-bounds (which is not very useful as auto-bounds were, and now are again, enabled by default). A new `auto_bounds()` API can now be sued to disable auto-bounds if needed. Fixes #3712 Fixes rerun-io/rerun#4503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of 2 of adding a better API for egui_plot's auto-bounds feature.
In this PR: add
auto_bounds()/set_auto_bounds()APIs to PlotUI