New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some distance between parent menu and submenu #4230

Merged

emilk merged 1 commit into master from emilk/tweak-menus

Mar 26, 2024

Owner

emilk commented Mar 26, 2024

Before:

After:


          Add some distance between parent menu and submenu

623fc80

emilk added egui style labels

emilk merged commit cf8c37c into master

37 checks passed

emilk deleted the emilk/tweak-menus branch

March 26, 2024 07:43

emilk mentioned this pull request

Improve spacing and alignment of menus rerun-io/rerun#5680

Merged

5 tasks

emilk added a commit to rerun-io/rerun that referenced this pull request


          Improve spacing and alignment of menus (#5680)

03db295

### What
Based on:
* emilk/egui#4232 
* emilk/egui#4230 
* emilk/egui#4233 

## Before
<img width="402" alt="Screenshot 2024-03-26 at 11 17 57"
src="https://github.com/rerun-io/rerun/assets/1148717/3a5f8d1d-ecff-49fe-8d7e-2a8a85289526">
<img width="581" alt="Screenshot 2024-03-26 at 11 17 40"
src="https://github.com/rerun-io/rerun/assets/1148717/fad07dd5-076a-4bf0-a8cd-dcb1369eddf8">

## After

<img width="599" alt="Screenshot 2024-03-26 at 11 20 36"
src="https://github.com/rerun-io/rerun/assets/1148717/dc4cc6d4-a117-4b6b-81b3-3fff6f64f247">

<img width="421" alt="Screenshot 2024-03-26 at 11 20 43"
src="https://github.com/rerun-io/rerun/assets/1148717/857b4767-17cd-4c23-8e28-4bd03881faed">

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5680/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5680/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5680/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5680)
- [Docs
preview](https://rerun.io/preview/003d45654e7ddf9335aa82d9c50d67dd5a0695c6/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/003d45654e7ddf9335aa82d9c50d67dd5a0695c6/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

hacknus pushed a commit to hacknus/egui that referenced this pull request


          Add some distance between parent menu and submenu (emilk#4230)

e5acb8a

Before:
<img width="502" alt="Screenshot 2024-03-26 at 08 37 16"
src="https://github.com/emilk/egui/assets/1148717/ca072cae-807a-4830-a59a-11ff822d0a7b">


After:
<img width="532" alt="Screenshot 2024-03-26 at 08 36 12"
src="https://github.com/emilk/egui/assets/1148717/f42d79f4-ff05-457f-9fab-67574839f025">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels