Don't try installing revoked Widevine CDM #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
I guess this can be merged now. |
mediaminister
force-pushed
the
revoked
branch
from
441d6b0 to
7f1aeba
Compare
mediaminister
force-pushed
the
revoked
branch
from
7f1aeba to
03613c4
Compare
mediaminister
force-pushed
the
revoked
branch
from
03613c4 to
d94ae37
Compare
mediaminister
force-pushed
the
revoked
branch
from
d94ae37 to
c1d625f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Sonarcloud reported a code smell, which you probably overlooked. Also, I think the warning message could be improved by mentioning that our detection mechanism might not be reliable due to technical limitations. |
|
I'll take another look. The length of the warning message should be short enough to fit the ok dialog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes no sense trying to install the older 4.10.1679.0 Widevine anymore since Google revoked it.