fixed more minor issues with the docs that I missed on first pass #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnor
approved these changes
Oct 5, 2023
|
Hi @huyndao and thanks again. The changes look good, merged now :) Regarding the logo, I also saw the same. Including the README in the docs was mostly a practical way to bootstrap the content of the docs site. Now that there are dedicated getting started sections etc., I think we can stop including it and instead have a dedicated introduction page for the docs. Then this issue will go away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonnor please review and approve.
Thanks again!
Huy
PS: I'm also seeing that the new logo does not show up properly on https://emlearn.readthedocs.io/en/latest/source/README.html, I don't think I can fix it since it shows properly on the README.md for the github page. If I fix one, it will break the other.