Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: reduce file reading high water mark to match Node.js v22 #1127

Merged
merged 2 commits into from
May 10, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented May 10, 2024

No description provided.

@emmercm emmercm self-assigned this May 10, 2024
@emmercm emmercm enabled auto-merge (squash) May 10, 2024 15:10
Copy link

github-actions bot commented May 10, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/reduce-high-water-mark" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (6171249) to head (eb37906).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1127   +/-   ##
=======================================
  Coverage   93.14%   93.14%           
=======================================
  Files          97       97           
  Lines        6275     6275           
  Branches     1400     1488   +88     
=======================================
  Hits         5845     5845           
+ Misses        429      409   -20     
- Partials        1       21   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 6b9a0cc into main May 10, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/reduce-high-water-mark branch May 10, 2024 17:09
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant