Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't test default cache paths when one provided #1145

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented May 31, 2024

Fixes: #1135

@emmercm emmercm self-assigned this May 31, 2024
@emmercm emmercm enabled auto-merge (squash) May 31, 2024 01:49
Copy link

github-actions bot commented May 31, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/1135-fix" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 71.87500% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 93.19%. Comparing base (4e9033a) to head (9ca83f5).

Files Patch % Lines
src/igir.ts 63.63% 8 Missing ⚠️
src/polyfill/fsPoly.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
- Coverage   93.26%   93.19%   -0.07%     
==========================================
  Files         102      102              
  Lines        6351     6364      +13     
  Branches     1513     1409     -104     
==========================================
+ Hits         5923     5931       +8     
- Misses        406      432      +26     
+ Partials       22        1      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit aa0d2d9 into main May 31, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/1135-fix branch May 31, 2024 02:28
Copy link

github-actions bot commented Jul 1, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--cache-path Option Being Ignored?
1 participant