Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: correct bad ROM extensions #1174

Merged
merged 35 commits into from
Jul 17, 2024
Merged

Feature: correct bad ROM extensions #1174

merged 35 commits into from
Jul 17, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jun 22, 2024

No description provided.

@emmercm emmercm self-assigned this Jun 22, 2024
@emmercm emmercm marked this pull request as ready for review July 12, 2024 16:14
@emmercm emmercm marked this pull request as draft July 12, 2024 16:14
@emmercm emmercm marked this pull request as ready for review July 12, 2024 16:14
@emmercm emmercm marked this pull request as draft July 12, 2024 16:19
@emmercm emmercm marked this pull request as ready for review July 17, 2024 01:53
@emmercm emmercm enabled auto-merge (squash) July 17, 2024 01:53
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 98.61111% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.21%. Comparing base (662ee57) to head (3678c87).

Files Patch % Lines
src/types/files/archives/archiveEntry.ts 80.00% 1 Missing ⚠️
src/types/files/file.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1174      +/-   ##
==========================================
+ Coverage   93.11%   93.21%   +0.10%     
==========================================
  Files         105      107       +2     
  Lines        6518     6646     +128     
  Branches     1536     1459      -77     
==========================================
+ Hits         6069     6195     +126     
- Misses        426      450      +24     
+ Partials       23        1      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit de38745 into main Jul 17, 2024
54 of 55 checks passed
@emmercm emmercm deleted the emmercm/extension-corrector branch July 17, 2024 02:00
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#main" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant