Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: dir letter limit option #496

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Feature: dir letter limit option #496

merged 6 commits into from
Jul 24, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 23, 2023

Fixes #490

@emmercm emmercm self-assigned this Jul 23, 2023
@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/dir-letter-limit" [commands..] [options]

@emmercm emmercm marked this pull request as ready for review July 24, 2023 00:52
@emmercm emmercm enabled auto-merge (squash) July 24, 2023 00:52
@codecov-commenter
Copy link

Codecov Report

Merging #496 (7fbaeab) into main (b8acf43) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   93.29%   93.40%   +0.11%     
==========================================
  Files          72       73       +1     
  Lines        4204     4276      +72     
  Branches      875      887      +12     
==========================================
+ Hits         3922     3994      +72     
  Misses        268      268              
  Partials       14       14              
Impacted Files Coverage Δ
src/modules/patchCandidateGenerator.ts 95.06% <ø> (ø)
src/igir.ts 100.00% <100.00%> (ø)
src/modules/argumentsParser.ts 100.00% <100.00%> (ø)
src/modules/candidateGenerator.ts 95.83% <100.00%> (-1.66%) ⬇️
src/modules/candidatePostProcessor.ts 100.00% <100.00%> (ø)
src/modules/combinedCandidateGenerator.ts 100.00% <100.00%> (ø)
src/types/files/archives/archive.ts 100.00% <100.00%> (ø)
src/types/files/archives/archiveEntry.ts 98.27% <100.00%> (ø)
src/types/files/file.ts 87.57% <100.00%> (+0.14%) ⬆️
src/types/options.ts 99.07% <100.00%> (+0.12%) ⬆️

... and 1 file with indirect coverage changes

@emmercm emmercm merged commit 4a4508f into main Jul 24, 2023
38 checks passed
@emmercm emmercm deleted the emmercm/dir-letter-limit branch July 24, 2023 01:18
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --dir-letter-limit option
2 participants