Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: dir2dat command #740

Merged
merged 41 commits into from
Dec 7, 2023
Merged

Feature: dir2dat command #740

merged 41 commits into from
Dec 7, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Oct 3, 2023

Fixes #626

Fixes #652

@emmercm emmercm self-assigned this Oct 3, 2023
Base automatically changed from emmercm/file-md5-sha1 to main October 3, 2023 04:36
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/dir2dat" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm marked this pull request as ready for review December 7, 2023 05:08
@emmercm emmercm enabled auto-merge (squash) December 7, 2023 05:19
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0cc9aec) 93.46% compared to head (3ff0381) 93.46%.

Files Patch % Lines
src/modules/argumentsParser.ts 93.93% 2 Missing ⚠️
src/types/dats/game.ts 77.77% 2 Missing ⚠️
src/modules/datScanner.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
- Coverage   93.46%   93.46%   -0.01%     
==========================================
  Files          85       86       +1     
  Lines        5252     5296      +44     
  Branches     1194     1214      +20     
==========================================
+ Hits         4909     4950      +41     
- Misses        325      328       +3     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 1df8ffb into main Dec 7, 2023
51 of 52 checks passed
@emmercm emmercm deleted the emmercm/dir2dat branch December 7, 2023 05:25
Copy link

github-actions bot commented Jan 7, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

status of fixdat when running igir dir2dat command
1 participant