Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: adopt more eslint-plugin-unicorn rules #764

Merged
merged 7 commits into from
Oct 14, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Oct 13, 2023

No description provided.

@emmercm emmercm self-assigned this Oct 13, 2023
@emmercm emmercm enabled auto-merge (squash) October 13, 2023 22:57
@github-actions
Copy link

github-actions bot commented Oct 13, 2023

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/20231013-unicorn" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #764 (a2db0ae) into main (1898207) will decrease coverage by 0.07%.
The diff coverage is 86.20%.

@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
- Coverage   93.69%   93.63%   -0.07%     
==========================================
  Files          83       83              
  Lines        5046     5014      -32     
  Branches     1128     1128              
==========================================
- Hits         4728     4695      -33     
  Misses        301      301              
- Partials       17       18       +1     
Files Coverage Δ
src/igir.ts 96.03% <100.00%> (-0.10%) ⬇️
src/modules/argumentsParser.ts 98.11% <100.00%> (ø)
src/modules/candidateCombiner.ts 100.00% <100.00%> (ø)
src/modules/candidateMergeSplitValidator.ts 71.05% <100.00%> (-1.45%) ⬇️
src/modules/candidatePatchGenerator.ts 94.66% <100.00%> (-0.21%) ⬇️
src/modules/candidatePostProcessor.ts 100.00% <100.00%> (ø)
src/modules/candidatePreferer.ts 100.00% <100.00%> (ø)
src/modules/datFilter.ts 100.00% <100.00%> (ø)
src/modules/datParentInferrer.ts 98.14% <100.00%> (ø)
src/modules/fileIndexer.ts 95.83% <100.00%> (ø)
... and 29 more

@emmercm emmercm merged commit e237847 into main Oct 14, 2023
51 of 52 checks passed
@emmercm emmercm deleted the emmercm/20231013-unicorn branch October 14, 2023 00:38
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant