Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: possible stack size limit issues when globbing many files #775

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Oct 21, 2023

No description provided.

@emmercm emmercm self-assigned this Oct 21, 2023
@emmercm emmercm enabled auto-merge (squash) October 21, 2023 17:34
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #775 (2589fe2) into main (0456459) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #775   +/-   ##
=======================================
  Coverage   93.73%   93.74%           
=======================================
  Files          83       83           
  Lines        5031     5034    +3     
  Branches     1134     1134           
=======================================
+ Hits         4716     4719    +3     
  Misses        298      298           
  Partials       17       17           
Files Coverage Δ
src/polyfill/fsPoly.ts 84.31% <100.00%> (+0.20%) ⬆️
src/types/options.ts 99.01% <100.00%> (+<0.01%) ⬆️

@github-actions
Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/glob-stack-size-limit" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm merged commit 1837a00 into main Oct 21, 2023
53 checks passed
@emmercm emmercm deleted the emmercm/glob-stack-size-limit branch October 21, 2023 17:49
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant