Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: ban Array#push() #792

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Refactor: ban Array#push() #792

merged 1 commit into from
Oct 27, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Oct 27, 2023

No description provided.

@emmercm emmercm self-assigned this Oct 27, 2023
@emmercm emmercm enabled auto-merge (squash) October 27, 2023 02:48
@github-actions
Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/ban-array-push" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #792 (dc33c23) into main (d034726) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
- Coverage   93.64%   93.64%   -0.01%     
==========================================
  Files          84       84              
  Lines        5132     5130       -2     
  Branches     1164     1164              
==========================================
- Hits         4806     4804       -2     
  Misses        309      309              
  Partials       17       17              
Files Coverage Δ
src/igir.ts 96.03% <100.00%> (ø)
src/modules/candidatePatchGenerator.ts 94.66% <100.00%> (ø)
src/modules/directoryCleaner.ts 96.15% <100.00%> (-0.15%) ⬇️
src/polyfill/fsPoly.ts 84.31% <100.00%> (ø)

@emmercm emmercm merged commit c83d577 into main Oct 27, 2023
53 checks passed
@emmercm emmercm deleted the emmercm/ban-array-push branch October 27, 2023 02:55
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant