Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: outputToken MinUI #817

Merged
merged 8 commits into from
Nov 29, 2023
Merged

Conversation

juliadin
Copy link
Contributor

MinUI is a tiny frontend for the trimui smart (pro), RG35XX, miyoo mini (plus) and the RGB30. It has some interesting concepts for sorting roms to folders and collections.

See https://github.com/shauninman/MinUI/blob/main/skeleton/BASE/README.txt (section 'Roms')

Copy link

github-actions bot commented Nov 19, 2023

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:juliadin/igir#feature-outputToken-minui" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@juliadin juliadin marked this pull request as ready for review November 19, 2023 19:11
@juliadin
Copy link
Contributor Author

MinUI is a little weird about folder names but it worked well on my device. MinUI is much more flexible than other systems. I'd be happy if igir could support it.

@juliadin
Copy link
Contributor Author

Hey @emmercm - would it be ok to introduce alphabetical sorting in the gameConsole.ts path associations so that the tags added are sorted consistently? I wanted to do this for a while since it's just a tiny chore to do but I didn't know if it was ok to do it 'on the side' because it touches a lot of lines not related to a feature. I'll do a separate pull request otherwise. some time later.

@juliadin
Copy link
Contributor Author

Same procedure as last time. This PR should - if you desire to do so - be merged before #833 :)

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d107a0b) 93.44% compared to head (0842c73) 93.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #817   +/-   ##
=======================================
  Coverage   93.44%   93.45%           
=======================================
  Files          85       85           
  Lines        5233     5238    +5     
  Branches     1190     1191    +1     
=======================================
+ Hits         4890     4895    +5     
  Misses        325      325           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 1f79a36 into emmercm:main Nov 29, 2023
51 of 52 checks passed
@emmercm
Copy link
Owner

emmercm commented Nov 29, 2023

Hey @emmercm - would it be ok to introduce alphabetical sorting in the gameConsole.ts path associations so that the tags added are sorted consistently? I wanted to do this for a while since it's just a tiny chore to do but I didn't know if it was ok to do it 'on the side' because it touches a lot of lines not related to a feature. I'll do a separate pull request otherwise. some time later.

Do you mean the interface properties, the getters, and the like? Yeah, I'm definitely for it, I know we talked about it at #804 (comment). Feel free to do it in #833, you're the only one touching this code at the moment 😄. Entirely your choice.

@emmercm
Copy link
Owner

emmercm commented Nov 29, 2023

Oh and sorry for the slow merges here, it's a busy time of the year with work, family, and holidays.

@juliadin
Copy link
Contributor Author

Thanks I will do so. :) - and no worries. It takes the time it takes. Thanks for the merge!

@juliadin juliadin deleted the feature-outputToken-minui branch November 29, 2023 05:01
juliadin pushed a commit to juliadin/igir that referenced this pull request Nov 29, 2023
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants