Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: skip candidate preference when not in 1G1R mode #820

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Nov 21, 2023

No description provided.

@emmercm emmercm self-assigned this Nov 21, 2023
@emmercm emmercm enabled auto-merge (squash) November 21, 2023 03:34
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cc2eb1) 93.44% compared to head (3b5062a) 93.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #820   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files          85       85           
  Lines        5230     5233    +3     
  Branches     1188     1190    +2     
=======================================
+ Hits         4887     4890    +3     
  Misses        325      325           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercan/candidate-preferer-shortcut" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm merged commit 9eb74a4 into main Nov 21, 2023
52 of 53 checks passed
@emmercm emmercm deleted the emmercan/candidate-preferer-shortcut branch November 21, 2023 03:41
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant