Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add PSP and PS Vita to sort PSX roms properly #838

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

juliadin
Copy link
Contributor

There is a problem where roms matched by dats with name 'PlayStation Portable' match the 'PlayStation' regex when using GameConsole output tokens and therefore platforms supporting the PSX receive all PSP roms as well. Mentioning the PSP (and for good measure PS Vita as well) should solve this for the time being. Batocera and JelOS support the PSP anyway.
Both are not caught by the ps[4-9] catchall ... but congrats for that idea :D

@juliadin juliadin marked this pull request as ready for review November 29, 2023 16:41
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46d25a1) 93.46% compared to head (2e45181) 93.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #838   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files          85       85           
  Lines        5252     5252           
  Branches     1194     1194           
=======================================
  Hits         4909     4909           
  Misses        325      325           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliadin
Copy link
Contributor Author

I may go through the supported frontend's lists of supported systems and add the other systems that are not listed in igir so far if that's ok. I am doing all this because i heavily use igir to manage my collection and all this is actually useful for me :) - i hope I am not spamming too much

Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:juliadin/igir#fix-playstation-portable" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm
Copy link
Owner

emmercm commented Nov 29, 2023

Feel free to keep going @juliadin! I'm very happy to accept these PRs. I may cut a release later today because of some bug fixes I tackled.

@juliadin
Copy link
Contributor Author

Will do, thanks. This is done, too, then. :)

@juliadin
Copy link
Contributor Author

And regarding the release later today, I don't think I will have any more PRs ready until then, sorry. I am swamped with work until later today.

@emmercm emmercm merged commit 89c81c4 into emmercm:main Nov 29, 2023
52 checks passed
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants