-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add PSP and PS Vita to sort PSX roms properly #838
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 85 85
Lines 5252 5252
Branches 1194 1194
=======================================
Hits 4909 4909
Misses 325 325
Partials 18 18 ☔ View full report in Codecov by Sentry. |
I may go through the supported frontend's lists of supported systems and add the other systems that are not listed in igir so far if that's ok. I am doing all this because i heavily use igir to manage my collection and all this is actually useful for me :) - i hope I am not spamming too much |
🧪 Branch testing instructionsThis pull request can be tested locally with the following command: npm exec --yes -- "github:juliadin/igir#fix-playstation-portable" [commands..] [options] Comment generated by the Pull Request Commenter workflow. |
Feel free to keep going @juliadin! I'm very happy to accept these PRs. I may cut a release later today because of some bug fixes I tackled. |
Will do, thanks. This is done, too, then. :) |
And regarding the release later today, I don't think I will have any more PRs ready until then, sorry. I am swamped with work until later today. |
🔒 Inactive pull request lockThis pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Comment generated by the GitHub Lock Issues workflow. |
There is a problem where roms matched by dats with name 'PlayStation Portable' match the 'PlayStation' regex when using GameConsole output tokens and therefore platforms supporting the PSX receive all PSP roms as well. Mentioning the PSP (and for good measure PS Vita as well) should solve this for the time being. Batocera and JelOS support the PSP anyway.
Both are not caught by the ps[4-9] catchall ... but congrats for that idea :D