Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove CandidateWriter test console.log()s #874

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jan 4, 2024

No description provided.

@emmercm emmercm self-assigned this Jan 4, 2024
@emmercm emmercm enabled auto-merge (squash) January 4, 2024 01:22
Copy link

github-actions bot commented Jan 4, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/remove-writer-console-logs" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (983c085) 93.43% compared to head (91b7257) 93.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #874   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          86       86           
  Lines        5301     5301           
  Branches     1215     1215           
=======================================
  Hits         4953     4953           
  Misses        330      330           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 639d30f into main Jan 4, 2024
48 checks passed
@emmercm emmercm deleted the emmercm/remove-writer-console-logs branch January 4, 2024 01:37
Copy link

github-actions bot commented Feb 3, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant