Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: consider every ROM of a BIOS game to be a BIOS file when merging & splitting #880

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jan 5, 2024

Fixes: #857

@emmercm emmercm self-assigned this Jan 5, 2024
Copy link

github-actions bot commented Jan 5, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/merge-split-bios-parent" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm marked this pull request as ready for review January 19, 2024 21:46
@emmercm emmercm enabled auto-merge (squash) January 19, 2024 21:46
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e8fd7a3) 93.42% compared to head (66c7a31) 93.11%.

Files Patch % Lines
src/modules/datMergerSplitter.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
- Coverage   93.42%   93.11%   -0.32%     
==========================================
  Files          86       86              
  Lines        5295     5298       +3     
  Branches     1215     1216       +1     
==========================================
- Hits         4947     4933      -14     
- Misses        330      346      +16     
- Partials       18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 71ead76 into main Jan 19, 2024
52 checks passed
@emmercm emmercm deleted the emmercm/merge-split-bios-parent branch January 19, 2024 21:50
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant