Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: dir-letter-group option #900

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Feature: dir-letter-group option #900

merged 4 commits into from
Feb 1, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Feb 1, 2024

Fixes: #837

@emmercm emmercm self-assigned this Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/dir-letter-group" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm enabled auto-merge (squash) February 1, 2024 01:08
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bc5540) 93.40% compared to head (c08536d) 93.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   93.40%   93.44%   +0.04%     
==========================================
  Files          86       86              
  Lines        5306     5342      +36     
  Branches     1218     1225       +7     
==========================================
+ Hits         4956     4992      +36     
  Misses        332      332              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 24491f3 into main Feb 1, 2024
51 checks passed
@emmercm emmercm deleted the emmercm/dir-letter-group branch February 1, 2024 01:15
Copy link

github-actions bot commented Mar 2, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 3 letter or more suffix to directories instead of letter only when roms exceed letter directory limit
1 participant