Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds full-text searching to Lux sites. #753

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Conversation

bwatson78
Copy link
Contributor

@bwatson78 bwatson78 commented Aug 11, 2023

  • app/assets/*, app/helpers/newspaper_works/newspaper_works_helper_behavior.rb, app/models/search_builder.rb, app/views/catalog/_snippets_more.html.erb, lib/newspaper_works/highlight_search_params.rb: imports code from the curate implementation.
  • app/controllers/catalog_controller.rb: adds all_text_tsimv field to search results and search options.
  • app/helpers/additional_catalog_helper.rb: includes imported method into appropriate module.
  • config/locales/blacklight.en.yml: imports localization from curate code, but changes the label verbiage per request.
  • spec/*: updates expectations.
  • spec/spec_helper.rb: sidesteps new webdriver Chrome behavior locally.

@bwatson78 bwatson78 added enhancement New feature or request Software Engineering Flag work for software engineering team ruby Pull requests that update Ruby code labels Aug 11, 2023
@bwatson78 bwatson78 requested review from alexBLR and abelemlih August 11, 2023 18:13
@bwatson78 bwatson78 self-assigned this Aug 11, 2023
@bwatson78
Copy link
Contributor Author

Screenshot 2023-08-11 at 1 19 40 PM

@abelemlih
Copy link
Collaborator

@bwatson78 The full text search functionality in Curate currently supports keyword highlighting when a search keyword matches the full text, as seen below:

Screenshot 2023-08-11 at 3 15 44 PM

Could you test whether the changes you added support keyword highlighting for full text search too?

@bwatson78
Copy link
Contributor Author

@abelemlih Pointed the css to the right element class.

@bwatson78
Copy link
Contributor Author

Screenshot 2023-08-14 at 7 54 48 AM

@abelemlih abelemlih merged commit cf542c9 into main Aug 14, 2023
@abelemlih abelemlih deleted the adds_full_text_search_lux branch August 14, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ruby Pull requests that update Ruby code Software Engineering Flag work for software engineering team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants