Accept All by "OK" without setting "default" to "true"

[astoun]

I have found out, that this is not properly works with orejime.
After opening the website for the first time I see the small window with "Accept", "Decline" and "Learn more" buttons.
The Accept button turn on only apps which set to default:true.
But this is not GDPR compliant!
The Accept button (should actually be called "Accept all") should set to an "enabled" all apps.
I see that klaro has fixed it: klaro-org/klaro-js#118
Can we also have it on orejime?
Thank you!

[sede1900]

indeed, it causes confusion
astourn is right, optionals apps can't be selected by default (analytics, social cookies...)

to get around this problem I force the modal to load the page but it's intrusive
I prefer a little banner in the footer
we need this behaviour

[seanthepottingshed]

@astoun @sede1971

As I'm not familiar with React I've used the following very hacky JS as a temp fix for this problem:

var orejimeTimer = setInterval(function() {
    if(typeof orejime !== 'undefined') {
        clearInterval(orejimeTimer);
        if(!document.cookie.match(/^(.*;)?\s*orejime\s*=\s*[^;]+(.*)?$/) && Object.keys(orejime.internals.manager.consents).length) {
            var learnMoreButton = document.getElementsByClassName('orejime-Notice-learnMoreButton')[0];
            learnMoreButton.addEventListener('click', function() {
                document.getElementsByClassName('orejime-AppToggles-disableAll')[0].click();
            });
            var acceptAllButton = document.getElementsByClassName('orejime-Notice-saveButton')[0];
            acceptAllButton.addEventListener('click', function() {
                for(var i in orejime.internals.manager.consents) {
                    orejime.internals.manager.consents[i] = true;
                }
                orejime.internals.manager.saveAndApplyConsents();
            });
        }
    }
}, 50);

[j1mb0b]

I have created a PR for this to get the ball rolling - #31

[ThibaultS]

Hello @felixgirault can you confirm that the 2.0.0 version don't fix this issue ?

[Fabsgugu]

@felixgirault

Bonjour,
J'ai testé la 2.0.0 et je n'ai vu aucune différence sur ce sujet. En acceptant les cookies, ceux qui sont en "false" par défaut ne sont pas acceptés. Je ne sais pas si c'est l'effet voulu en fusionnant uniquement l'issue #41. J'ai pas l'impréssion en tout cas qu'il y a une option à activer.

A moins que j'ai raté quelque chose dans les paramétrages, je pense qu'il faudrait tout de même mettre en place cette option, pour être bon avec la RGPD.

[felixgirault]

Hi @ThibaultS @Fabsgugu,
The pull request was meant to fix the issue.
If it is not, there a bug I didn't see, sorry for the inconvenience.
I'm reopening the issue and I'll try to investigate as soon as I can. However if you've got a fix at hand, please open a PR :)

[felixgirault]

Okay, I let some really huge mistakes make their way to v2.
I was in a rush and I didn't test enough, sorry again.
I published a v2.0.1 that should fix the abovementioned problem, and I deprecated v2.0.0 on npm.

[felixgirault]

I'm closing the issue for now since the last version should be ok.