Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connections-detail):use event listeners instead of onsize events #1379

Merged
merged 1 commit into from Jul 28, 2023

Conversation

ni00
Copy link
Contributor

@ni00 ni00 commented Jul 28, 2023

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

window.onresize events can bind only one event at a time, causing overrides
(multiple components use window.onresize events)

Issue Number

#1354

What is the new behavior?

use event listeners instead of onsize events

refer link: https://www.cnblogs.com/wangweizhang/p/12874679.html

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ni00 ni00 added fix Fix bug or issues desktop MQTTX Desktop labels Jul 28, 2023
@ni00 ni00 requested a review from ysfscream July 28, 2023 06:06
@ni00 ni00 self-assigned this Jul 28, 2023
@ni00 ni00 added this to the v1.9.5 milestone Jul 28, 2023
@ni00 ni00 linked an issue Jul 28, 2023 that may be closed by this pull request
@ysfscream ysfscream merged commit 9d4dfa9 into emqx:main Jul 28, 2023
1 check passed
@ni00 ni00 deleted the layout-dev branch July 31, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop fix Fix bug or issues
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Layout issue after maximising (new in v1.9.4)
2 participants