feat(deps): use specified node version for build #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Red-Asuka
approved these changes
Sep 25, 2023
Red-Asuka
requested changes
Sep 25, 2023
There was a problem hiding this comment.
@Rotzbua node-version-file seems to be supported only in versions above actions/setup-node 2.5.0, please update actions/setup-node version.
Rory-Z
approved these changes
Sep 25, 2023
Red-Asuka
approved these changes
Sep 27, 2023
Swilder-M
approved these changes
Sep 27, 2023
|
@Rotzbua Before merging, I'd like to confirm one thing: Have you tested to ensure that we can still build a functional package after this change? We want to ensure this modification doesn't adversely affect our current build process. I'm looking forward to hearing back from you! |
ysfscream
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Node version for build environment is defined in the GH Actions scripts.
Issue Number
none
What is the new behavior?
Use central config file to manage node version.
Does this PR introduce a breaking change?
Specific Instructions
none
Other information
none