Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(msg): payload type table migration and update #1562

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

ysfscream
Copy link
Member

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Please describe the current behavior and link to a relevant issue.

Add a new cbor type, the error in the console.

image

Issue Number

Example: #1547

What is the new behavior?

Manually update the migration script to change the payload type to a more flexible and extensible string type to facilitate future expansion. It is very troublesome to update using a simple enum due to the limitation of typeorm.

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added enhancement New feature or request migration database migration desktop MQTTX Desktop labels Jan 17, 2024
@ysfscream ysfscream added this to the v1.9.9 milestone Jan 17, 2024
@ysfscream ysfscream self-assigned this Jan 17, 2024
@Red-Asuka Red-Asuka merged commit a3d5eeb into main Jan 17, 2024
2 checks passed
@Red-Asuka Red-Asuka deleted the ysf/1.9/dev branch January 17, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request migration database migration
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants