Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(desktop): display the reason and code for the disconnection #1616

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

XL-YiBai
Copy link
Contributor

@XL-YiBai XL-YiBai commented Mar 30, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Please describe the current behavior and link to a relevant issue.

Issue Number

#1329

What is the new behavior?

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

This feature is only supported when using MQTT 5.0
desktop & web:
image
image
image
image

cli:

[2024/3/30] [21:42:09] › ⚠  The Broker has actively disconnected, Reason: Administrative action (Code: 152)
[2024/3/30] [21:52:40] › ⚠  Client ID: test_4, The Broker has actively disconnected, Reason: Administrative action (Code: 152)
[2024/3/30] [21:52:40] › ⚠  Client ID: test_5, The Broker has actively disconnected, Reason: Administrative action (Code: 152)
[2024/3/30] [21:52:40] › ⚠  Client ID: test_6, The Broker has actively disconnected, Reason: Administrative action (Code: 152)

@XL-YiBai XL-YiBai marked this pull request as ready for review March 30, 2024 09:12
@XL-YiBai XL-YiBai self-assigned this Mar 30, 2024
@XL-YiBai XL-YiBai added feature This pr is a feature desktop MQTTX Desktop web MQTTX Web enhancement New feature or request labels Mar 30, 2024
@XL-YiBai XL-YiBai marked this pull request as draft March 30, 2024 09:14
@XL-YiBai XL-YiBai added the CLI MQTTX CLI label Mar 30, 2024
@XL-YiBai XL-YiBai marked this pull request as ready for review March 30, 2024 15:04
src/lang/connections.ts Outdated Show resolved Hide resolved
@ysfscream ysfscream added this to the v1.9.10 milestone Apr 1, 2024
Copy link
Member

@ysfscream ysfscream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution and for fixing the issue.

@ysfscream ysfscream merged commit f0a2602 into emqx:main Apr 1, 2024
6 checks passed
@XL-YiBai XL-YiBai deleted the my/main branch April 1, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI MQTTX CLI desktop MQTTX Desktop enhancement New feature or request feature This pr is a feature web MQTTX Web
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants