Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): update gtm configuration #1704

Merged
merged 1 commit into from
Jun 24, 2024
Merged

chore(web): update gtm configuration #1704

merged 1 commit into from
Jun 24, 2024

Conversation

Red-Asuka
Copy link
Member

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Please describe the current behavior and link to a relevant issue.

Issue Number

Example: #123

What is the new behavior?

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@Red-Asuka Red-Asuka added chore Changes in build tools or dependent packages web MQTTX Web labels Jun 24, 2024
@Red-Asuka Red-Asuka requested a review from ysfscream June 24, 2024 09:58
@Red-Asuka Red-Asuka self-assigned this Jun 24, 2024
@ysfscream ysfscream added this to the v1.10.1 milestone Jun 24, 2024
@@ -19,8 +19,8 @@ Vue.use(VueClipboard)
Vue.use(VueVirtualScroller)
Vue.use(VueRx)
Vue.use(VueGtm, {
id: 'GTM-K487G9S',
enabled: process.env.NODE_ENV === 'production' && process.env.BASE_URL === '/online-mqtt-client/',
id: 'GTM-KHSFXHT',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe here? Maybe we need to add it to the env file?

@ysfscream ysfscream merged commit a2955c1 into main Jun 24, 2024
4 checks passed
@ysfscream ysfscream deleted the lyd/dev branch June 24, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes in build tools or dependent packages web MQTTX Web
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants