Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ruleengine): adjusted the scope of client_attrs in the rule engine #13604

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Aug 13, 2024

Fixes EMQX-12390

Release version: v/e5.8.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review August 13, 2024 11:20
@lafirest lafirest requested review from kjellwinblad and a team as code owners August 13, 2024 11:20
@lafirest lafirest merged commit 3057d68 into emqx:release-58 Aug 14, 2024
183 checks passed
@lafirest lafirest deleted the fix/cattrs branch August 14, 2024 04:15
@emqxqa
Copy link

emqxqa commented Aug 15, 2024

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants